added Request form api #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeper into crudRequestForms
ChiragJS
requested review from
SundarakrishnanN and
chrisvrose
and removed request for
SundarakrishnanN
chrisvrose
reviewed
Mar 3, 2024
| import org.springframework.web.bind.annotation.ResponseStatus; | ||
|
|
||
| @ResponseStatus(HttpStatus.BAD_REQUEST) | ||
| public class PDFNotConversionException extends Exception{ |
There was a problem hiding this comment.
FailedFileConversionException?
If you want to keep the same name, pls add a javadoc mentioning what this exception means
chrisvrose
reviewed
Mar 3, 2024
| throw new PDFNotConversionException("Could not store pdf"); | ||
| } | ||
|
|
||
| return requestFormService.save(requestForm); |
There was a problem hiding this comment.
This returns the entire thing as JSON. how is the file returned?
If as a json array, that will make the response too huge, could you check?
chrisvrose
reviewed
Mar 3, 2024
|
ignore this pr,made a newer one with slightly cleaner code |
|
Please close if not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to remove RequestDTO class, no use of it . update the put mapping in the next Pr
made an urgent pr !