Add Society API #10
Merged
Add Society API #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvrose
requested review from
Prajwalprakash3722,
SundarakrishnanN and
ChiragJS
Closed
Prajwalprakash3722
approved these changes
Feb 13, 2024
| } | ||
|
|
||
| @GetMapping | ||
| public List<Society> list(){ |
There was a problem hiding this comment.
Is there a standardized format for data return, such as ResultDTO?
There was a problem hiding this comment.
I thought of that, but decided to not since current API design so far isn't using it either.
In retrospect, it is much more standard to check the response code than the "ok" field.
There was a problem hiding this comment.
It would make much more sense to have consistent data return across all end point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a Society API and convenience configurations.
Changes
Created required CRUD apis for Society.
Added the
modelmapperdependency. This allows us to use DTOs so that we can define what fields are taken as input (and not just the whole entity.Updated society field
isActivetoactive. This is because the getter can beisActive, and still make sense.Update the society entity to have createdAt and updatedAt. These values will be automatically set by Hibernate, as required.
Added an
ItemNotFoundException. When this error is thrown, this will automatically map to a404response.