Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added accounts and login features #29

Merged
merged 6 commits into from
Nov 25, 2023
Merged

Conversation

anirudhprabhakaran3
Copy link
Member

Description

Adds accounts and login to Corpus.

Fixes #18, #19

Dependencies

None

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Test A
  • Test B

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@anirudhprabhakaran3 anirudhprabhakaran3 linked an issue Sep 20, 2023 that may be closed by this pull request
2 tasks
@anirudhprabhakaran3
Copy link
Member Author

Oh I have to add tests for accounts. Will do that over this week and weekend.

@nishant-nayak
Copy link
Member

nishant-nayak commented Sep 21, 2023

Convert your PR to draft if tests are pending to be added.

Also, please run the pre-commit hooks before making commits. I'm catching a lot of issues that are supposed to be caught and fixed by the pre-commit hooks.

Run pre-commit run --all once you've installed the pre-commit hooks.

@anirudhprabhakaran3 anirudhprabhakaran3 changed the title Added accounts and login features Draft: Added accounts and login features Sep 22, 2023
@nishant-nayak nishant-nayak marked this pull request as draft September 25, 2023 04:22
@render
Copy link

render bot commented Oct 23, 2023

@anirudhprabhakaran3 anirudhprabhakaran3 self-assigned this Oct 23, 2023
@anirudhprabhakaran3 anirudhprabhakaran3 changed the title Draft: Added accounts and login features Added accounts and login features Oct 23, 2023
@livecycle
Copy link

livecycle bot commented Oct 23, 2023

ieee-nitk

Your Livecycle playground is ready 🎉.

Playground version up to date (23192fc)

Invite team members and start collaborating 💪

Members already invited
  • Nishant Nayak
  • Anirudh Prabhakaran

Click here to invite the rest of your team.

Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of comments, mostly styling related.

Logic wise code seems alright, if you're stuck on styling let me know and I'll try pitching in some code.

corpus/accounts/tests.py Show resolved Hide resolved
corpus/accounts/tests.py Show resolved Hide resolved
corpus/templates/base.html Show resolved Hide resolved
corpus/templates/accounts/signup.html Outdated Show resolved Hide resolved
corpus/templates/accounts/login.html Outdated Show resolved Hide resolved
corpus/templates/accounts/login.html Outdated Show resolved Hide resolved
Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nishant-nayak nishant-nayak merged commit 1e7f0ca into main Nov 25, 2023
2 checks passed
@nishant-nayak nishant-nayak deleted the add_login_to_corpus branch November 25, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login Page Registration Page
2 participants