-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added accounts and login features #29
Conversation
Oh I have to add tests for accounts. Will do that over this week and weekend. |
Convert your PR to draft if tests are pending to be added. Also, please run the pre-commit hooks before making commits. I'm catching a lot of issues that are supposed to be caught and fixed by the pre-commit hooks. Run |
Your Render PR Server URL is https://corpus-dev-pr-29.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-ckr5sc81hnes73fruiog. |
ieee-nitkYour Livecycle playground is ready 🎉.✅ Playground version up to date (23192fc) Invite team members and start collaborating 💪 Members already invited
Click here to invite the rest of your team. |
82c495e
to
372f52d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a bunch of comments, mostly styling related.
Logic wise code seems alright, if you're stuck on styling let me know and I'll try pitching in some code.
4ea2cb2
to
45e085a
Compare
45e085a
to
a8d0a71
Compare
Signed-off-by: Nishant Nayak <[email protected]>
Signed-off-by: Nishant Nayak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Adds accounts and login to Corpus.
Fixes #18, #19
Dependencies
None
Type of Change
What types of changes does your code introduce?
Put an
x
in the boxes that applyHow Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.