Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back to Django #16

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Bring back to Django #16

merged 5 commits into from
Aug 25, 2023

Conversation

anirudhprabhakaran3
Copy link
Member

Revert everything back so that we have a pure Django application.

Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the nginx configured for development? If you think we do, the rest of the changes look good to me.

@anirudhprabhakaran3
Copy link
Member Author

Yeah, am removing that. Also, I'm actually planning to interchange the production and normal docker compose files, so that we have to run docker compose without the -f flag. Would make developers' lives easier.

Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README with updated commands for Docker Development, remove unnecessary sections (like frontend), etc.

Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the additional documentation for contributors.

@nishant-nayak nishant-nayak merged commit 938bd47 into main Aug 25, 2023
1 check passed
@nishant-nayak nishant-nayak deleted the remove_svelte branch August 25, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants