-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDR 0.4.4 merge branch #50
Conversation
Most open PRs targeted at IDR 0.4.4 have been integrated. Is this merge branch still necessary? |
Are the new files in this PR needed to be added to master?
What about the changes in ansible/idr-09-monitoring.yml and ansible/management-grafana.yml |
Thanks for checking, I've rebased this and added the remaining commits to: |
General question: how do we know that there are not other commits used for deployment that have been forgotten? |
Same as before, diff master against this branch? |
The question is more: do we have other ways to validate that the diff? |
Looking at https://github.com/manics/deployment/compare/idr-0-4-4...snoopycrimecop:master/merge/trigger?expand=1 is the extra |
Isn't that in #70 ? |
👍 GitHub branch comparison API has limitations when comparing differences between 2 integrations branchess but a manual |
All PRs have now been integrated into |
This will be split into separate PRs.
--on-hold
--exclude
Main changes:
/shared
scratch space in jupyterhub notebooks/srv/www/src/
and added initial config to support Add IDR version string to footer idr.openmicroscopy.org#24