Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile fix for PS5 platform #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MicheleCaovilla
Copy link

Fix for issue #34 by Reply Game Studios

@jonpas
Copy link
Member

jonpas commented Jan 11, 2025

ImPlot changes should be made upstream.

@MicheleCaovilla
Copy link
Author

ImPlot changes should be made upstream.

Sorry, I rarely use git for public projects so I'm not a PR expert. What am I supposed to do? Pushing ImPlot changes to the ImPlot repo? Thanks

@jonpas
Copy link
Member

jonpas commented Jan 14, 2025

Yes, files in ThirdParty should not be specifically changed in this repo (except configuration).

However, PLATFORM_PS5 comes from Unreal, so it should not be used in those projects either. We should instead define something those projects expect to have defined to make those changes.

@MicheleCaovilla
Copy link
Author

Yes, files in ThirdParty should not be specifically changed in this repo (except configuration).

However, PLATFORM_PS5 comes from Unreal, so it should not be used in those projects either. We should instead define something those projects expect to have defined to make those changes.

Thanks for the explanation.

We could do something like #define IMGUI_DISABLE_DEFAULT_SHELL_FUNCTIONS in the ImGui file. I'll try to work on it over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants