content: 1.1.12

[esmeetewinkel]

Use preview URL to see that highlighted task group populates correctly initially, but then disappears on refresh.

Screenshot:

Screen video:

Screenity.video.-.Oct.7.2024.webm

[github-actions]

Visit the preview URL for this PR (updated for commit d4122f8):

https://parenting-for-respectability--pr109-content-1-1-12-nliq0ibu.web.app

_{(expires Tue, 22 Oct 2024 15:37:01 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: fadc6f41d770cf5a50996f703271c184e2fae6fe}

[esmeetewinkel]

@jfmcquade on Mattermost

Hi. I tracked down the source of the task completion bug. It was indeed a change I made in the sprint before the Kuwait meeting. I could go into lots of detail, but the issue is that this commit essentially made "completed" be the default name for the column that tracks task completion via dynamic data. I didn't realise at the time, but that was a breaking change because it means that data lists that use that column name are automatically assumed to be using dynamic data. But for some older deployments, we use that column name without using dynamic data.

If I remember correctly, the use of that column name, and its assignment to the value @[email protected]_field was essentially an authoring convention to make it easier to grab the completed value of a given task in the app: rather than getting the value by looking up a field like @field.{@data.my_data_list.my_task_row.completed_field}, we can just use @data.my_data_list.my_task_row.completed, and since that value references the field, it would grab the current field value. This is essentially a shorthand, and completely separate from the dynamic data implementation of tasks, which uses a completed column to store a boolean value that gets updated via a set_item action.

So my proposal for a fix:
Re-author deployments that make use of a completed column in this way (to reference a @field. value) to rename that column, e.g. completed -> completed_value. This avoids using the now protected column name "completed", which should only be used for dynamic data tasks. This will also involve updating all references throughout the deployment to refer to @data.my_data_list.my_task_row.completed_value (or whatever name is best) instead of @data.my_data_list.my_task_row.completed.

Does that seem sensible? At some point we will probably want to update the old deployments to make use of the dynamic data feature when handling tasks, but I think this intermediary fix would be worth it.