Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inheritance #129

Merged
merged 14 commits into from
Jun 26, 2024
Merged

Add support for inheritance #129

merged 14 commits into from
Jun 26, 2024

Conversation

geoo89
Copy link
Collaborator

@geoo89 geoo89 commented May 18, 2024

Repos can now reference data from other repos.

The design follows the proposal outlined here: #125

An application can be seen in the last commit of the following PR: IDEMSInternational/parenttext-crisis#51

The main thing to be aware of after this is merged is that to run the pipeline the command has changed from

python -m parenttext_pipeline.cli

to

python -m parenttext_pipeline.cli pull_data compile_flows

@edmoss345
Copy link
Collaborator

edmoss345 commented Jun 12, 2024

@geoo89 ran the check that we discussed in the meeting, all looks good. Vanilla crisis was still running ok so think we are safe to merge without disrupting legacy deployments. Had to add a bit of encoding detail as we discussed, also had to make some changes in the toolkit which can be seen here:

IDEMSInternational/rapidpro-flow-toolkit#134

If you are happy with that, both need to be merged at the same time so can I leave that to you since I dont think I have permissions in the toolkit repo.

I also added in the latest QR function as well so this should be up to date. @fagiothree the main thing to be aware of after this is merged is that to run the pipeline the command has changed from

python -m parenttext_pipeline.cli

to

python -m parenttext_pipeline.cli pull_data compile_flows

@geoo89 geoo89 merged commit 23e4a69 into main Jun 26, 2024
1 check passed
@geoo89 geoo89 deleted the feat/inheritance branch July 10, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants