Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: increase payload size limit #2809

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

jfmcquade
Copy link
Collaborator

@jfmcquade jfmcquade commented Feb 24, 2025

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

increases the size limit on body payloads posted to API server. This is required to resolve an issue where attempting to sync user data would result in a 413 (Payload Too Large) response to the POST request to the server.

Solution taken from this answer.

The value of 32mb was chosen to match the client_max_body_size as specified in packages/server/docker/config/nginx/templates/server.conf.template, but could likely be much lower.

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, oh yeah I can see the default is 100kb so seems reasonable to bump it.

I can see why matching the server limit makes sense, although I'm going to reduce to 2mb as I think if we start reaching payloads that sort of size would really want to come up with a better mechanism to sync

I'll deploy to the server and check whether all working as expected

@chrismclarke
Copy link
Member

Server updated, can confirm larger payloads accepted when testing locally

Before
image

After
image

@chrismclarke chrismclarke merged commit 4f576e7 into master Feb 24, 2025
6 checks passed
@chrismclarke chrismclarke deleted the server/increase-payload-size-limit branch February 24, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants