Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user debug sidebar route #2806

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

chrismclarke
Copy link
Member

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Add support to include /user debug page as a sidebar content target, e.g. /template/home_screen(sidebar:user)

Git Issues

Closes #

Screenshots/Videos

Example - user debug page sidebar alongside templated content
image

Copy link

Visit the preview URL for this PR (updated for commit c0cc618):

https://plh-teens-app1--pr2806-feat-user-debug-side-to5zmgbz.web.app

(expires Thu, 13 Mar 2025 16:44:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c0bab6b08dd290fbf002fd6e07987fa4b5fce1

Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test passed.

Just noting that the dynamic data in the user sidebar doesn't update dynamically with the template, it requires a refresh to show the latest.

Screenity.video.-.Feb.27.2025.webm

@esmeetewinkel esmeetewinkel merged commit 4d6eb54 into master Feb 27, 2025
11 checks passed
@esmeetewinkel esmeetewinkel deleted the feat/user-debug-sidebar branch February 27, 2025 17:10
@chrismclarke
Copy link
Member Author

Functional test passed.

Just noting that the dynamic data in the user sidebar doesn't update dynamically with the template, it requires a refresh to show the latest.

I noticed similar myself. It might be worth including as a follow-up issue to get it to live-update for improved debugging, along with the suggestions from #2815

@esmeetewinkel
Copy link
Collaborator

Follow up issue: #2826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules test - preview Create a preview deployment of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants