-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plh_module_list_item highlighted param and circle variant #2805
feat: plh_module_list_item highlighted param and circle variant #2805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment: The comparison between the two styles would be slightly more consistent to me if the blue and yellow border styles were the same size also for the circle
variant. In that case, across both variants:
- locked: smaller, greyed out, lock appears
- unlocked (independent of whether or not it's highlighted): larger
This also seems desirable from a user perspective, where the initial state of the app they will see is circle
variant with 1 unlocked unhighlighted module and the other modules locked unhighlighted.
@esmeetewinkel yeh that makes sense. I think you're suggesting two changes if I've understood correctly:
Is that right? If so:
|
@jfmcquade Thanks for writing that down more clearly. I was suggesting only 2., your point 1. is not actually bugging me much. So let's leave 1. as is and action 2. |
…://github.com/IDEMSInternational/parenting-app-ui into feat/plh_module_list_item-highlighted-variant
@esmeetewinkel I've updated with bec9f03 and have updated the screenshots in the PR description acordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test passed.
PR Checklist
Description
Updates the
plh_module_list_item
component:highlighted
circle
circle
variant of thetask_card
componenthighlighted
/locked
parametersplh_kids_kw
deployment homepageFollow-up
If the new circle variant is sufficient, and the task card's circle variant is no longer needed, the latter should be removed from the code, is it was always a somewhat messy workaround for a specific use-case.
Git Issues
Closes #2756
Related issues: #2763, ParentingForLifelongHealth/plh-kids-app-kw-content#145
Screenshots/Videos
comp_plh_module_list_item template:
comp_plh_progress_path