-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Google Sign In button component #2788
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d630d35
feat: Google Sign In button variant
jfmcquade bd80037
chore: rename variant to 'google_sign_in'
jfmcquade 657aa55
chore: RTL styling
jfmcquade 0823c00
chore: add explanatory comment
jfmcquade 3c7a79f
chore: extract google sign in button to standalone component
jfmcquade 9c55308
Merge branch 'master' into feat/google-auth-button
jfmcquade File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
...components/template/components/button/google-sign-in/button-google-sign-in.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
<!-- HTML copied from https://developers.google.com/identity/branding-guidelines | ||
with Theme: Light; Shape: Pill --> | ||
<button class="gsi-material-button"> | ||
<div class="gsi-material-button-state"></div> | ||
<div class="gsi-material-button-content-wrapper"> | ||
<div class="gsi-material-button-icon"> | ||
<svg | ||
version="1.1" | ||
xmlns="http://www.w3.org/2000/svg" | ||
viewBox="0 0 48 48" | ||
xmlns:xlink="http://www.w3.org/1999/xlink" | ||
style="display: block" | ||
> | ||
<path | ||
fill="#EA4335" | ||
d="M24 9.5c3.54 0 6.71 1.22 9.21 3.6l6.85-6.85C35.9 2.38 30.47 0 24 0 14.62 0 6.51 5.38 2.56 13.22l7.98 6.19C12.43 13.72 17.74 9.5 24 9.5z" | ||
></path> | ||
<path | ||
fill="#4285F4" | ||
d="M46.98 24.55c0-1.57-.15-3.09-.38-4.55H24v9.02h12.94c-.58 2.96-2.26 5.48-4.78 7.18l7.73 6c4.51-4.18 7.09-10.36 7.09-17.65z" | ||
></path> | ||
<path | ||
fill="#FBBC05" | ||
d="M10.53 28.59c-.48-1.45-.76-2.99-.76-4.59s.27-3.14.76-4.59l-7.98-6.19C.92 16.46 0 20.12 0 24c0 3.88.92 7.54 2.56 10.78l7.97-6.19z" | ||
></path> | ||
<path | ||
fill="#34A853" | ||
d="M24 48c6.48 0 11.93-2.13 15.89-5.81l-7.73-6c-2.15 1.45-4.92 2.3-8.16 2.3-6.26 0-11.57-4.22-13.47-9.91l-7.98 6.19C6.51 42.62 14.62 48 24 48z" | ||
></path> | ||
<path fill="none" d="M0 0h48v48H0z"></path> | ||
</svg> | ||
</div> | ||
<span class="gsi-material-button-contents">{{ value }}</span> | ||
<span style="display: none">{{ value }}</span> | ||
</div> | ||
</button> |
118 changes: 118 additions & 0 deletions
118
...components/template/components/button/google-sign-in/button-google-sign-in.component.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
/* CSS copied from https://developers.google.com/identity/branding-guidelines | ||
with Theme: Light; Shape: Pill | ||
The only modification is using `margin-inline-end` instead of `margin-right` to support RTL languages | ||
*/ | ||
|
||
.gsi-material-button { | ||
-moz-user-select: none; | ||
-webkit-user-select: none; | ||
-ms-user-select: none; | ||
-webkit-appearance: none; | ||
background-color: WHITE; | ||
background-image: none; | ||
border: 1px solid #747775; | ||
-webkit-border-radius: 20px; | ||
border-radius: 20px; | ||
-webkit-box-sizing: border-box; | ||
box-sizing: border-box; | ||
color: #1f1f1f; | ||
cursor: pointer; | ||
font-family: "Roboto", arial, sans-serif; | ||
font-size: 14px; | ||
height: 40px; | ||
letter-spacing: 0.25px; | ||
outline: none; | ||
overflow: hidden; | ||
padding: 0 12px; | ||
position: relative; | ||
text-align: center; | ||
-webkit-transition: | ||
background-color 0.218s, | ||
border-color 0.218s, | ||
box-shadow 0.218s; | ||
transition: | ||
background-color 0.218s, | ||
border-color 0.218s, | ||
box-shadow 0.218s; | ||
vertical-align: middle; | ||
white-space: nowrap; | ||
width: auto; | ||
max-width: 400px; | ||
min-width: min-content; | ||
} | ||
|
||
.gsi-material-button .gsi-material-button-icon { | ||
height: 20px; | ||
margin-inline-end: 12px; | ||
min-width: 20px; | ||
width: 20px; | ||
} | ||
|
||
.gsi-material-button .gsi-material-button-content-wrapper { | ||
-webkit-align-items: center; | ||
align-items: center; | ||
display: flex; | ||
-webkit-flex-direction: row; | ||
flex-direction: row; | ||
-webkit-flex-wrap: nowrap; | ||
flex-wrap: nowrap; | ||
height: 100%; | ||
justify-content: space-between; | ||
position: relative; | ||
width: 100%; | ||
} | ||
|
||
.gsi-material-button .gsi-material-button-contents { | ||
-webkit-flex-grow: 1; | ||
flex-grow: 1; | ||
font-family: "Roboto", arial, sans-serif; | ||
font-weight: 500; | ||
overflow: hidden; | ||
text-overflow: ellipsis; | ||
vertical-align: top; | ||
} | ||
|
||
.gsi-material-button .gsi-material-button-state { | ||
-webkit-transition: opacity 0.218s; | ||
transition: opacity 0.218s; | ||
bottom: 0; | ||
left: 0; | ||
opacity: 0; | ||
position: absolute; | ||
right: 0; | ||
top: 0; | ||
} | ||
|
||
.gsi-material-button:disabled { | ||
cursor: default; | ||
background-color: #ffffff61; | ||
border-color: #1f1f1f1f; | ||
} | ||
|
||
.gsi-material-button:disabled .gsi-material-button-contents { | ||
opacity: 38%; | ||
} | ||
|
||
.gsi-material-button:disabled .gsi-material-button-icon { | ||
opacity: 38%; | ||
} | ||
|
||
.gsi-material-button:not(:disabled):active .gsi-material-button-state, | ||
.gsi-material-button:not(:disabled):focus .gsi-material-button-state { | ||
background-color: #303030; | ||
opacity: 12%; | ||
} | ||
|
||
.gsi-material-button:not(:disabled):hover { | ||
-webkit-box-shadow: | ||
0 1px 2px 0 rgba(60, 64, 67, 0.3), | ||
0 1px 3px 1px rgba(60, 64, 67, 0.15); | ||
box-shadow: | ||
0 1px 2px 0 rgba(60, 64, 67, 0.3), | ||
0 1px 3px 1px rgba(60, 64, 67, 0.15); | ||
} | ||
|
||
.gsi-material-button:not(:disabled):hover .gsi-material-button-state { | ||
background-color: #303030; | ||
opacity: 8%; | ||
} |
10 changes: 10 additions & 0 deletions
10
...d/components/template/components/button/google-sign-in/button-google-sign-in.component.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { Component, Input } from "@angular/core"; | ||
|
||
@Component({ | ||
selector: "tmpl-button-google-sign-in", | ||
templateUrl: "./button-google-sign-in.component.html", | ||
styleUrls: ["./button-google-sign-in.component.scss"], | ||
}) | ||
export class TmplButtonGoogleSignInComponent { | ||
@Input() value: any; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit(blocking): Given that the google_sign_in button has very specific behaviour I think it would be best if not included in default button component as a variant, but instead be it's own standalone component, e.g.
google_sign_in_button
. I can see most of the code you have already put in it's own file, but I think probably best not including in the basebutton
component at allLonger term we would likely plan around feature modules also registering their own components (like modules do), and so likely this would be something like an
auth_google_sign_in_button
component, although I think keeping asgoogle_sign_in
is still fine. It should by default include the action to sign in with google, and any user-defined action_list could be triggered after