Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Google Sign In button component #2788

Merged
merged 6 commits into from
Feb 14, 2025
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<ng-container [ngSwitch]="variantMap().cardPortrait">
@if (!variantMap().cardPortrait && !variantMap().googleSignIn) {
<!-- Default variant -->
<ion-button
*ngSwitchDefault
[class]="'full standard medium' + ' ' + params().style + ' ' + params().buttonAlign"
[disabled]="params().disabled"
(click)="triggerActions('click')"
Expand Down Expand Up @@ -41,10 +40,9 @@
></plh-template-component>
</span>
</ion-button>

} @else if (variantMap().cardPortrait) {
<!-- "card-portrait" variant. This variant is not achievable using an ion-button -->
<div
*ngSwitchCase="true"
class="button-container"
(click)="handleClick()"
[attr.data-variant]="params().variant"
Expand All @@ -65,4 +63,10 @@
></plh-template-component>
</span>
</div>
</ng-container>
} @else if (variantMap().googleSignIn) {
<!-- Google Sign In variant -->
<tmpl-button-google-sign-in
[value]="value()"
(click)="handleClick()"
></tmpl-button-google-sign-in>
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ interface IButtonParams {
| "card-portrait"
| "flexible"
| "full"
| "google_sign_in"
Copy link
Member

@chrismclarke chrismclarke Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit(blocking): Given that the google_sign_in button has very specific behaviour I think it would be best if not included in default button component as a variant, but instead be it's own standalone component, e.g. google_sign_in_button. I can see most of the code you have already put in it's own file, but I think probably best not including in the base button component at all

Longer term we would likely plan around feature modules also registering their own components (like modules do), and so likely this would be something like an auth_google_sign_in_button component, although I think keeping as google_sign_in is still fine. It should by default include the action to sign in with google, and any user-defined action_list could be triggered after

| "information"
| "medium"
| "navigation"
Expand Down Expand Up @@ -42,6 +43,7 @@ interface IButtonParams {

interface IVariantMap {
cardPortrait?: boolean;
googleSignIn?: boolean;
}

/**
Expand Down Expand Up @@ -102,6 +104,7 @@ export class TmplButtonComponent extends TemplateBaseComponent {
const variantArray = variant.split(" ");
return {
cardPortrait: variantArray.includes("card-portrait"),
googleSignIn: variantArray.includes("google_sign_in"),
};
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<!-- HTML copied from https://developers.google.com/identity/branding-guidelines
with Theme: Light; Shape: Pill -->
<button class="gsi-material-button">
<div class="gsi-material-button-state"></div>
<div class="gsi-material-button-content-wrapper">
<div class="gsi-material-button-icon">
<svg
version="1.1"
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 48 48"
xmlns:xlink="http://www.w3.org/1999/xlink"
style="display: block"
>
<path
fill="#EA4335"
d="M24 9.5c3.54 0 6.71 1.22 9.21 3.6l6.85-6.85C35.9 2.38 30.47 0 24 0 14.62 0 6.51 5.38 2.56 13.22l7.98 6.19C12.43 13.72 17.74 9.5 24 9.5z"
></path>
<path
fill="#4285F4"
d="M46.98 24.55c0-1.57-.15-3.09-.38-4.55H24v9.02h12.94c-.58 2.96-2.26 5.48-4.78 7.18l7.73 6c4.51-4.18 7.09-10.36 7.09-17.65z"
></path>
<path
fill="#FBBC05"
d="M10.53 28.59c-.48-1.45-.76-2.99-.76-4.59s.27-3.14.76-4.59l-7.98-6.19C.92 16.46 0 20.12 0 24c0 3.88.92 7.54 2.56 10.78l7.97-6.19z"
></path>
<path
fill="#34A853"
d="M24 48c6.48 0 11.93-2.13 15.89-5.81l-7.73-6c-2.15 1.45-4.92 2.3-8.16 2.3-6.26 0-11.57-4.22-13.47-9.91l-7.98 6.19C6.51 42.62 14.62 48 24 48z"
></path>
<path fill="none" d="M0 0h48v48H0z"></path>
</svg>
</div>
<span class="gsi-material-button-contents">{{ value }}</span>
<span style="display: none">{{ value }}</span>
</div>
</button>
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
/* CSS copied from https://developers.google.com/identity/branding-guidelines
with Theme: Light; Shape: Pill
The only modification is using `margin-inline-end` instead of `margin-right` to support RTL languages
*/

.gsi-material-button {
-moz-user-select: none;
-webkit-user-select: none;
-ms-user-select: none;
-webkit-appearance: none;
background-color: WHITE;
background-image: none;
border: 1px solid #747775;
-webkit-border-radius: 20px;
border-radius: 20px;
-webkit-box-sizing: border-box;
box-sizing: border-box;
color: #1f1f1f;
cursor: pointer;
font-family: "Roboto", arial, sans-serif;
font-size: 14px;
height: 40px;
letter-spacing: 0.25px;
outline: none;
overflow: hidden;
padding: 0 12px;
position: relative;
text-align: center;
-webkit-transition:
background-color 0.218s,
border-color 0.218s,
box-shadow 0.218s;
transition:
background-color 0.218s,
border-color 0.218s,
box-shadow 0.218s;
vertical-align: middle;
white-space: nowrap;
width: auto;
max-width: 400px;
min-width: min-content;
}

.gsi-material-button .gsi-material-button-icon {
height: 20px;
margin-inline-end: 12px;
min-width: 20px;
width: 20px;
}

.gsi-material-button .gsi-material-button-content-wrapper {
-webkit-align-items: center;
align-items: center;
display: flex;
-webkit-flex-direction: row;
flex-direction: row;
-webkit-flex-wrap: nowrap;
flex-wrap: nowrap;
height: 100%;
justify-content: space-between;
position: relative;
width: 100%;
}

.gsi-material-button .gsi-material-button-contents {
-webkit-flex-grow: 1;
flex-grow: 1;
font-family: "Roboto", arial, sans-serif;
font-weight: 500;
overflow: hidden;
text-overflow: ellipsis;
vertical-align: top;
}

.gsi-material-button .gsi-material-button-state {
-webkit-transition: opacity 0.218s;
transition: opacity 0.218s;
bottom: 0;
left: 0;
opacity: 0;
position: absolute;
right: 0;
top: 0;
}

.gsi-material-button:disabled {
cursor: default;
background-color: #ffffff61;
border-color: #1f1f1f1f;
}

.gsi-material-button:disabled .gsi-material-button-contents {
opacity: 38%;
}

.gsi-material-button:disabled .gsi-material-button-icon {
opacity: 38%;
}

.gsi-material-button:not(:disabled):active .gsi-material-button-state,
.gsi-material-button:not(:disabled):focus .gsi-material-button-state {
background-color: #303030;
opacity: 12%;
}

.gsi-material-button:not(:disabled):hover {
-webkit-box-shadow:
0 1px 2px 0 rgba(60, 64, 67, 0.3),
0 1px 3px 1px rgba(60, 64, 67, 0.15);
box-shadow:
0 1px 2px 0 rgba(60, 64, 67, 0.3),
0 1px 3px 1px rgba(60, 64, 67, 0.15);
}

.gsi-material-button:not(:disabled):hover .gsi-material-button-state {
background-color: #303030;
opacity: 8%;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { Component, Input } from "@angular/core";

@Component({
selector: "tmpl-button-google-sign-in",
templateUrl: "./button-google-sign-in.component.html",
styleUrls: ["./button-google-sign-in.component.scss"],
})
export class TmplButtonGoogleSignInComponent {
@Input() value: any;
}
2 changes: 2 additions & 0 deletions src/app/shared/components/template/components/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { TmplAdvancedDashedBoxComponent } from "./layout/advanced-dashed-box/adv
import { TmplAnimatedSlidesComponent } from "./animated-slides/animated-slides.component";
import { TmplAudioComponent } from "./audio/audio.component";
import { TmplButtonComponent } from "./button/button.component";
import { TmplButtonGoogleSignInComponent } from "./button/google-sign-in/button-google-sign-in.component";
import { TmplCarouselComponent } from "./carousel/carousel.component";
import { TmplComboBoxComponent } from "./combo-box/combo-box.component";
import { TmplDashedBoxComponent } from "./dashed-box/dashed-box.component";
Expand Down Expand Up @@ -87,6 +88,7 @@ export const TEMPLATE_COMPONENTS = [
TmplAnimatedSlidesComponent,
TmplAudioComponent,
TmplButtonComponent,
TmplButtonGoogleSignInComponent,
TmplCarouselComponent,
TmplComboBoxComponent,
TmplDashedBoxComponent,
Expand Down
Loading