Mexico Theme: Refactor Theme-level Color Palette #2716
Merged
+22
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfmcquade
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Thanks @FaithDaka, I'm happy with this. Ideally our automatic theme colour generation should be flexible enough to handle different types of colours, but in the meantime it makes sense that designers may want to override the default generated values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
The current
utils.generateThememethod creates a large contrast for shades of green. The lower numbers (50-500) are too neon while the higher numbers (600-900) are sparsely dark.This theme refactor overrides the primary color palette with the actual design values, to create a cohesive palette.
Typography style file also removed as it's not needed.
Git Issues
Closes #2713
Screenshots