Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Accordion markdown text colour #2699

Merged
merged 3 commits into from
Jan 14, 2025
Merged

[BUG] Accordion markdown text colour #2699

merged 3 commits into from
Jan 14, 2025

Conversation

FaithDaka
Copy link
Collaborator

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Styles the accordion text to white using the standard class.

Git Issues

Closes #2696

@FaithDaka FaithDaka linked an issue Jan 9, 2025 that may be closed by this pull request
[FEATURE] KUWAIT: Markdown text in accordion should be white #2696
Closed
@FaithDaka FaithDaka self-assigned this Jan 9, 2025
jfmcquade
jfmcquade approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The "system" we have of applying classes to text like standard, normal and large, is quite painful to me and should really be revisited. But if this resolves an immediate issue then I'm happy with it for now.

esmeetewinkel
esmeetewinkel approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test passed

image

@esmeetewinkel esmeetewinkel merged commit 9632e75 into master Jan 14, 2025
6 checks passed
@esmeetewinkel esmeetewinkel deleted the feature-kw-accordion-md branch January 14, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esmeetewinkel esmeetewinkel esmeetewinkel approved these changes

@jfmcquade jfmcquade jfmcquade approved these changes

Assignees

@FaithDaka FaithDaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] KUWAIT: Markdown text in accordion should be white
3 participants
@FaithDaka @jfmcquade @esmeetewinkel