chore: audio component handles RTL languages (LTR player controls enforced) #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
maintenance
|
Visit the preview URL for this PR (updated for commit 3ad6d77): https://plh-teens-app1--pr2657-chore-audio-componen-2o49ck40.web.app (expires Mon, 13 Jan 2025 09:04:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e4c0bab6b08dd290fbf002fd6e07987fa4b5fce1 |
esmeetewinkel
approved these changes
Dec 30, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
The audio component handles cases where the app language direction is right-to-left (RTL). This is achieved by enforcing the player controls to be displayed in their default LTR styling, regardless of app language direction, in accordance with the description of #2617.
Git Issues
Closes #2617
Screenshots/Videos
plh_kids_kw