[FEATURE] Kuwait Theme - Completion Pop up variant #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…pp-builder into feature-kw-pop-up-component-variant
jfmcquade
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Thanks @FaithDaka, looks good. It could be worth updating the PR description with something like the following:
Adds variant functionality to pop-ups, where the named variant is passed in at the point of launching the pop-up. Currently only one variant is implemented, specifically for the
plh_kids_kwtheme.
| @@ -2,6 +2,7 @@ | |||
| class="popup-backdrop" | |||
| (click)="dismissOnBackdrop($event)" | |||
| [attr.data-fullscreen]="props.fullscreen ? true : null" | |||
| [attr.data-variant]="props.variant ? props.variant : null" | |||
There was a problem hiding this comment.
nit(non-blocking) This could be simplified to props.variant || null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
A new variant for the pop_up component that can be used as the completion modal.
Author Notes
variant:
plh_completionGit Issues
Closes #2635
Screenshots