Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuwait Theme: Custom styling for display-group 'box_*' variants #2604

Merged
merged 7 commits into from
Jan 2, 2025

Conversation

jfmcquade
Copy link
Collaborator

@jfmcquade jfmcquade commented Dec 6, 2024

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Breaks out changes originally included in #2589.

Adds custom styling for plh_kids_kw theme to display group component variants box_primary, box_secondary, box_gray, box_white.

Possibly these would be better as new variants, which would be required if we intend to use some version of the pre-existing variant styles in the KW app.

Git Issues

Closes #

Screenshots/Videos

feature_display_group template:

Design Kuwait Style

Copy link

github-actions bot commented Dec 16, 2024

Visit the preview URL for this PR (updated for commit a047c6b):

https://plh-teens-app1--pr2604-kuwait-kw-custom-dis-gl6bdyql.web.app

(expires Thu, 16 Jan 2025 15:36:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c0bab6b08dd290fbf002fd6e07987fa4b5fce1

Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice! LTR is working well, but the component doesn't currently adapt to RTL. Could that be added here?

image

RTL design:
image

@esmeetewinkel
Copy link
Collaborator

Looking nice! LTR is working well, but the component doesn't currently adapt to RTL. Could that be added here?

@FaithDaka is this something you could look at?

@jfmcquade
Copy link
Collaborator Author

@esmeetewinkel I've pushed changes so that the styling will adjust for RTL languages:

Screenshot 2025-01-02 at 15 30 04 Screenshot 2025-01-02 at 15 30 15

I believe it should be good to merge if it looks right to you.

@FaithDaka tagging you for awareness, the CSS properties I've used in 3c77723 were new to me

Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test passed

@esmeetewinkel esmeetewinkel merged commit b6936d4 into master Jan 2, 2025
8 checks passed
@esmeetewinkel esmeetewinkel deleted the kuwait/kw-custom-display-group-box-styling branch January 2, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test - preview Create a preview deployment of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants