-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kuwait Theme: Custom styling for display-group 'box_*' variants #2604
Kuwait Theme: Custom styling for display-group 'box_*' variants #2604
Conversation
Visit the preview URL for this PR (updated for commit a047c6b): https://plh-teens-app1--pr2604-kuwait-kw-custom-dis-gl6bdyql.web.app (expires Thu, 16 Jan 2025 15:36:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e4c0bab6b08dd290fbf002fd6e07987fa4b5fce1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FaithDaka is this something you could look at? |
@esmeetewinkel I've pushed changes so that the styling will adjust for RTL languages: I believe it should be good to merge if it looks right to you. @FaithDaka tagging you for awareness, the CSS properties I've used in 3c77723 were new to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test passed
PR Checklist
Description
Breaks out changes originally included in #2589.
Adds custom styling for
plh_kids_kw
theme to display group component variantsbox_primary
,box_secondary
,box_gray
,box_white
.Possibly these would be better as new variants, which would be required if we intend to use some version of the pre-existing variant styles in the KW app.
Git Issues
Closes #
Screenshots/Videos
feature_display_group template: