-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kuwait Comp: Bottom Navbar #2508
Conversation
…pp-builder into feat/bottom-nav
…pp-builder into feat/bottom-nav
…al/open-app-builder into feat/bottom-nav
I have a few things I want to achieve in this PR:
Item 3 has been done (with some static styling). It's 1 and 2 that are a WIP and need insights |
Thanks Faith, all sounds like good options to have at the core app layout level. Am I right in thinking that only the main section would have routing included and the other two sections single templates? If so it may be worth considering using something like a slider/modals/overlays to display the section content so that a user will always be returned to the same place when resuming main section (it never actually is removed from the dom). This wouldn't really work if the other sections were routable, in which case we could still look into using angular child routers. Remind me @jfmcquade how we've handled bottom navbars in the past and whether we've had a similar use case? |
Apologies, I've not had time to properly engage with this fully, but I think your plan sounds good, @FaithDaka
I believe we have one way to configure a footer: via the Since the footer is applied at the deployment config/skin level, we don't currently have any functionality for displaying a footer on some pages and not others. |
…pp-builder into feat/bottom-nav
Now that #2631 is merged, we can properly test this component in situ. I've updated the component demo template and will update the PR description. @FaithDaka there was an issue with the active link logic. We can't track @esmeetewinkel I believe this PR should now be ready for your functional testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test passed.
nit (non-blocking): I was surprised to find that the navigation only works correctly when the plh_bottom_nav
component is used in the footer - clicking any of the icons directly in the template leads to the app's home screen.
PR Checklist
Description
Includes a dynamic navigation bar component for the Kuwait app.
Git Issues
Closes #
Screenshots/Videos
comp_plh_bottom_nav
Parameter list (making use of the changes in #2631):