chore: move plh-specific components to plh components folder #2485
+46
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
Follow-up to #2478.
packages/components/plh
folder created in that PR, updating the relevant module declaration and component mappingparent-point-box
The code for these plh components is messy and includes hardcoded paths to assets. I don't think refactoring them is a priority right now, and I'm not sure if we plan to continue actively using them.
@FaithDaka – I think it's worth saying for your benefit that the two components that are now in
packages/components/plh
as of this PR are not good examples of components in themselves! They just happen to be two components that are PLH-specific so I've moved them over. You shouldn't look at the content of those files for an example of how to write component files (instead refer topackages/components/demo/basic
). However, how they are configured and declared inpackages/components/plh/index.ts
is relevant for adding any new PLH components.Git Issues
Closes #
Screenshots/Videos
Updated comp_parent_point_counter:
comp_parent_point_box. This component sheet doesn't make sense to me, and some assets are missing, but for the purposes of this PR, what is relevant is that this template displays the same on this PR branch as it does on the debug web preview, indicating that the component is being made available to the template authoring as expected