Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iOS footer bug #2281

Merged
merged 3 commits into from
Apr 5, 2024
Merged

fix: iOS footer bug #2281

merged 3 commits into from
Apr 5, 2024

Conversation

jfmcquade
Copy link
Collaborator

@jfmcquade jfmcquade commented Apr 5, 2024

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Fixes an issue where the icons displayed in the footer on iOS would intermittently disappear.

Testing

Appetize build here.

Dev notes

The solution ended up being extremely simple, but I'm still not sure what was causing the issue. The width of the .image-wrapper element was 0 when the icons were not visible, but it is not clear to me why the width needs to be set explicitly on iOS and not on other platforms. I haven't found discussion of this issue online, but it does appear to be a genuine bug at some level, as the behaviour was inconsistent and sporadic (see video in comments of original issue).

Git Issues

Closes #2243

Screenshots/Videos

Demonstration of icons not disappearing in iPhone simulator. As the behaviour was that the icons would occasionally disappear, it is not possible to prove empirically that this has been solved, however they would reasonably consistently disappear when navigating between templates, so we can be confident that the issue is fixed through functional testing (and the fact that the CSS changes directly address the cause of the issue).

Screen.Recording.2024-04-05.at.11.50.05.mov

Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I no longer see the footer icons disappearing 👍

I did encounter a potentially unrelated issue:
On the debug emulator build that you link in this PR description, the key board does (most of the time?) not pop up properly on a text box component or on the template list search box

Screenity.video.-.Apr.5.2024.webm

I'm not sure if this is introduced by this PR. Comparing this against an iOS build (plh_facilitator_mx) you produced yesterday, it seems that the key board does work properly there...
image

@esmeetewinkel esmeetewinkel self-requested a review April 5, 2024 13:06
Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction to my previous review:

I did also encounter the inconsistent keyboard behaviour on yesterday's emulator release, so the issue is not caused by this PR.
image

Tracked separately in issue #2283, I'll approve this PR.

@esmeetewinkel esmeetewinkel merged commit 128cc10 into master Apr 5, 2024
6 checks passed
@esmeetewinkel esmeetewinkel deleted the fix/ios-footer branch April 5, 2024 13:18
@chrismclarke
Copy link
Member

chrismclarke commented Apr 5, 2024

weird indeed, although I do wonder if it might also be linked to the other element positioning bugs...
@jfmcquade
I would probably suggest you add a quick comment in the style code to the issue as it's the type of thing I could imagine another developer viewing as 'unnecessary' and removing in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] iOS: footer template
3 participants