Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test actions #2278

Merged
merged 15 commits into from
Apr 5, 2024
Merged

fix: test actions #2278

merged 15 commits into from
Apr 5, 2024

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Apr 4, 2024

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

  • Fix test-preview action to handle firebase json as required
  • Deprecate unused actions
  • Simplify core web-build action (not reusable version) to remove previous branch deployment/.... logic (now handled by content repos)
  • Update test-visual action

Review notes

Example test-preview action pass
Example test-visual action pass

Author notes

I've removed the functionality for automated actions based on this repo deployment/[name] branches - as I'm assuming all content is now managed in content repos (?). If that is the case we may also want to remove the deployment and deployment_dev branches from this repo as a follow-up

Dev Notes

I had originally planned to try use the current set of reusable actions, essentially triggering them as part of the builder repo (and loading debug content repo), although it made things a little more complicated than I was hoping for so ended up simply refactoring the existing actions - so we still have 2 separate systems in place, one for actions related just to the builder repo and another for reusable actions triggered by content repos.

I did at least manage to remove what was essentially a third system, whereby actions could be triggered against deployment branches. I've also tried to keep it fairly similar to how variables are set on deployment repos, with the following secrets and variables currently set in a debug environment for this repo

image

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all content is now managed in content repos (?). We may also want to remove the deployment and deployment_dev branches from this repo as a follow-up

Yes that's correct, I'll remove these branches. Recently one such branch was useful to retrieve a previous deployed app version. But since deleted branches can be restored anyway, I don't see a problem deleting them (and having a cleaner code repo).

Copy link
Collaborator

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Using an environment for the secrets/variables seems like a nice pattern that simplifies the build actions and could be extended in future.

@github-actions github-actions bot added fix and removed fix labels Apr 5, 2024
@jfmcquade jfmcquade merged commit 5203508 into master Apr 5, 2024
10 checks passed
@jfmcquade jfmcquade deleted the refactor/debug-gh-actions branch April 5, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix test - preview Create a preview deployment of the PR test - visual Run visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants