-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: test actions #2278
fix: test actions #2278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all content is now managed in content repos (?). We may also want to remove the deployment and deployment_dev branches from this repo as a follow-up
Yes that's correct, I'll remove these branches. Recently one such branch was useful to retrieve a previous deployed app version. But since deleted branches can be restored anyway, I don't see a problem deleting them (and having a cleaner code repo).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Using an environment for the secrets/variables seems like a nice pattern that simplifies the build actions and could be extended in future.
PR Checklist
Description
deployment/....
logic (now handled by content repos)Review notes
Example
test-preview
action passExample
test-visual
action passAuthor notes
I've removed the functionality for automated actions based on this repo
deployment/[name]
branches - as I'm assuming all content is now managed in content repos (?). If that is the case we may also want to remove the deployment and deployment_dev branches from this repo as a follow-upDev Notes
I had originally planned to try use the current set of reusable actions, essentially triggering them as part of the builder repo (and loading debug content repo), although it made things a little more complicated than I was hoping for so ended up simply refactoring the existing actions - so we still have 2 separate systems in place, one for actions related just to the builder repo and another for reusable actions triggered by content repos.
I did at least manage to remove what was essentially a third system, whereby actions could be triggered against deployment branches. I've also tried to keep it fairly similar to how variables are set on deployment repos, with the following secrets and variables currently set in a
debug
environment for this repoGit Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes