Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android workflow variables #2276

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Apr 4, 2024

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Fix issue where android workflow would try to populate firebase templates

Review Notes

Should be able to successfully run the android workflow command with any deployment set that is configured for android

yarn workflow android

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

@github-actions github-actions bot added fix and removed fix labels Apr 4, 2024
@github-actions github-actions bot added fix and removed fix labels Apr 4, 2024
Copy link
Collaborator

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and yarn workflow android (configure) works for me locally. It generates a firebase.json file but does not try to populate the ${FIREBASE_HOSTING_TARGET} variable – should generating the firebase.json file from the template ultimately be handled by a different workflow command?

@chrismclarke
Copy link
Member Author

Looks good and yarn workflow android (configure) works for me locally. It generates a firebase.json file but does not try to populate the ${FIREBASE_HOSTING_TARGET} variable – should generating the firebase.json file from the template ultimately be handled by a different workflow command?

Yes it should, issues previously raised as #2236, but for now shouldn't cause issue as these files are overwritten by shell scripts when running firebase deployment actions

Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running yarn workflow android configure I can see the file firebase.json gets created.

@github-actions github-actions bot added fix and removed fix labels Apr 5, 2024
@esmeetewinkel esmeetewinkel merged commit 9792c7d into master Apr 5, 2024
6 checks passed
@esmeetewinkel esmeetewinkel deleted the fix/android-workflow-variables branch April 5, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants