-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: android workflow variables #2276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and yarn workflow android (configure)
works for me locally. It generates a firebase.json
file but does not try to populate the ${FIREBASE_HOSTING_TARGET}
variable – should generating the firebase.json
file from the template ultimately be handled by a different workflow command?
Yes it should, issues previously raised as #2236, but for now shouldn't cause issue as these files are overwritten by shell scripts when running firebase deployment actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running yarn workflow android configure
I can see the file firebase.json
gets created.
PR Checklist
Description
Fix issue where android workflow would try to populate firebase templates
Review Notes
Should be able to successfully run the android workflow command with any deployment set that is configured for android
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes