Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use primary colour for icons and text in header when header colour is 'none' #2229

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

jfmcquade
Copy link
Collaborator

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Follow up to #2216. As pointed out in this comment, when the header colour is none, the icons and text in the header should appear in the primary app colour.

Git Issues

Closes #

Screenshots/Videos

With deployment config:

config.app_config.APP_HEADER_DEFAULTS.colour = "none";
Screenshot 2024-03-11 at 13 06 21

With deployment config:

config.app_config.APP_HEADER_DEFAULTS.colour = "none";
config.app_config.APP_HEADER_DEFAULTS.variant = "compact";
Screenshot 2024-03-11 at 13 00 28

Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test passed

@esmeetewinkel esmeetewinkel merged commit d44eb13 into master Mar 13, 2024
6 checks passed
@esmeetewinkel esmeetewinkel deleted the style/header-icon-colour branch March 13, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants