Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace default favicon with IDEMS trefoil #2203

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

jfmcquade
Copy link
Collaborator

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Changes the default favicon, which is displayed in browsers when the config.favicon_asset value is not overridden as is possible since #2192, from the ionic logo to IDEMS's trefoil knot logomark

Git Issues

Closes #

Screenshots/Videos

Browser tab showing the new default favicon:
Screenshot 2024-02-13 at 10 35 43

@github-actions github-actions bot added the feature Work on app features/modules label Feb 13, 2024
@github-actions github-actions bot added feature Work on app features/modules and removed feature Work on app features/modules labels Feb 13, 2024
Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

image

@github-actions github-actions bot added feature Work on app features/modules and removed feature Work on app features/modules labels Feb 20, 2024
@esmeetewinkel esmeetewinkel merged commit eb86e9c into master Feb 20, 2024
8 checks passed
@esmeetewinkel esmeetewinkel deleted the feat/favicon-expose-path branch February 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants