Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove legacy images #2191

Merged
merged 2 commits into from
Jan 31, 2024
Merged

chore: Remove legacy images #2191

merged 2 commits into from
Jan 31, 2024

Conversation

esmeetewinkel
Copy link
Collaborator

@esmeetewinkel esmeetewinkel commented Jan 31, 2024

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

As I was playing around with favicon.png, I discovered some legacy assets in the code repo under src > assets. This PR is removing the ones that I'm convinced are not used.

Review notes

  1. Could you confirm I'm not breaking anything by removing these?

  2. Potentially some more images could be removed (remaining ones in screenshot below)

    image

@esmeetewinkel esmeetewinkel changed the title Remove legacy images chore: Remove legacy images Jan 31, 2024
@github-actions github-actions bot added the maintenance Core updates, refactoring and code quality improvements label Jan 31, 2024
@github-actions github-actions bot added maintenance Core updates, refactoring and code quality improvements and removed maintenance Core updates, refactoring and code quality improvements labels Jan 31, 2024
@jfmcquade
Copy link
Collaborator

Well spotted, I think they can safely be removed. I've pushed a commit that deletes a few more: the only ones that are in use are the tick.svg and cross.svg, which are being used in the toggle bar component. This should be changed with a refactor of that component, which could be done as part of fixing the toggle bar for #2157

@esmeetewinkel esmeetewinkel merged commit f91f096 into master Jan 31, 2024
8 checks passed
@esmeetewinkel esmeetewinkel deleted the remove-legacy-assets branch January 31, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Core updates, refactoring and code quality improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants