Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): add skip refresh flag to deployment set #2174

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Dec 18, 2023

PR Checklist

  • [x ] PR title descriptive (can be used in release notes)

Description

Add flag to allow skipping auto remote content refresh when setting a deployment

Review Notes

Set a deployment that has remote repo (e.g. debug), use the --skip-refresh flag to ensure updates not pulled from remote, e.g.

yarn workflow deployment set [name] --skip-refresh

Screenshots

Refresh step shows as skipped
image

@github-actions github-actions bot added the feature Work on app features/modules label Dec 18, 2023
@github-actions github-actions bot removed the feature Work on app features/modules label Dec 18, 2023
@github-actions github-actions bot added the feature Work on app features/modules label Dec 18, 2023
@github-actions github-actions bot added feature Work on app features/modules and removed feature Work on app features/modules labels Dec 19, 2023
Copy link
Collaborator

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, working for me locally.

I can see uses for this when developing new features. For example, when making changes to the debug deployment config as part of developing a new feature, I have previously had to lose my WIP changes if I want to change deployment and work on something else.

@github-actions github-actions bot added feature Work on app features/modules and removed feature Work on app features/modules labels Jan 30, 2024
@jfmcquade
Copy link
Collaborator

As requested in this mattermost thread

@github-actions github-actions bot added feature Work on app features/modules and removed feature Work on app features/modules labels Jan 30, 2024
@chrismclarke chrismclarke removed the request for review from ChrisMarsh82 January 30, 2024 15:15
@chrismclarke chrismclarke merged commit d3b260d into master Jan 30, 2024
8 checks passed
@chrismclarke chrismclarke deleted the feat/deployment-set-flags branch January 30, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants