Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump octokit from 1.8.1 to 3.1.2 #2172

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 16, 2023

Bumps octokit from 1.8.1 to 3.1.2.

Release notes

Sourced from octokit's releases.

v3.1.2

3.1.2 (2023-11-15)

Bug Fixes

  • updates app.js for the handling of an error being thrown by the verify method in webhooks.js (#2576) (b59da80)

v3.1.1

3.1.1 (2023-09-25)

Bug Fixes

v3.1.0

3.1.0 (2023-07-26)

Features

v3.0.0

3.0.0 (2023-07-11)

Features

BREAKING CHANGES

  • Drop support for NodeJS v14, v16
  • Remove previews support for the REST API
  • remove agent option from octokit.request()
  • Replace support for Node.js http(s) Agents with documentation on using fetch dispatchers instead (via @octokit/request)
  • Remove ability to pass custom request options, except for method, headers, body, signal (via @​octokit/request)

v3.0.0-beta.5

3.0.0-beta.5 (2023-07-11)

Bug Fixes

v3.0.0-beta.4

... (truncated)

Commits
  • b59da80 fix: updates app.js for the handling of an error being thrown by the verify m...
  • f514e4b build(deps): lock file maintenance (#2574)
  • fdc9bba chore(deps): update dependency prettier to v3.1.0
  • d3a9984 build(deps): lock file maintenance
  • 870d89d build(deps): lock file maintenance (#2565)
  • 78735dd build(deps): lock file maintenance (#2562)
  • 72ea679 chore(deps): update dependency @​types/node to v20
  • 692f7db ci(action): update actions/setup-node action to v4 (#2560)
  • 5b47b84 build(deps): lock file maintenance (#2558)
  • 941c584 docs: fixing typos in README (#2557)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 16, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/octokit-3.1.2 branch from 44337fb to 76f7413 Compare January 10, 2024 09:59
Bumps [octokit](https://github.com/octokit/octokit.js) from 1.8.1 to 3.1.2.
- [Release notes](https://github.com/octokit/octokit.js/releases)
- [Commits](octokit/octokit.js@v1.8.1...v3.1.2)

---
updated-dependencies:
- dependency-name: octokit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/octokit-3.1.2 branch from 76f7413 to 7ed471a Compare January 11, 2024 11:41
@github-actions github-actions bot added the maintenance Core updates, refactoring and code quality improvements label Jan 30, 2024
@github-actions github-actions bot added maintenance Core updates, refactoring and code quality improvements and removed maintenance Core updates, refactoring and code quality improvements labels Feb 20, 2024
@github-actions github-actions bot added maintenance Core updates, refactoring and code quality improvements and removed maintenance Core updates, refactoring and code quality improvements labels Feb 23, 2024
@jfmcquade jfmcquade added the test - visual Run visual regression tests label Feb 23, 2024
Copy link

github-actions bot commented Feb 23, 2024

Visual Test Summary
new : 0
different : 5
same : 329

Largest Differences
1 | 0.3 % | comp_radio_button_grid
2 | 0.3 % | parameters
3 | 0.2 % | example_calc_date
4 | 0.1 % | example_calc
5 | 0 % | feature_parent_point_box

Download Link
https://nightly.link/IDEMSInternational/parenting-app-ui/actions/runs/8083837757

Run Details
https://github.com/IDEMSInternational/parenting-app-ui/actions/runs/8083837757

Copy link
Collaborator

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Library is only used in test-visual package. The relevant action seems to be running as expected on this PR, there are no errors are flagged in the code, and there are no breaking changes in the release notes that are unaccounted for. So should be good to merge.

NB, Octokit now supposedly requires node v17+#2157 already expects devs to be using v18+, so this is not a problem (although all actions should be updated at some point to target more recent node versions).

@esmeetewinkel
Copy link
Collaborator

@jfmcquade Could you resolve the conflicts and merge?

image

@github-actions github-actions bot added maintenance Core updates, refactoring and code quality improvements and removed maintenance Core updates, refactoring and code quality improvements labels Feb 28, 2024
@github-actions github-actions bot added maintenance Core updates, refactoring and code quality improvements and removed maintenance Core updates, refactoring and code quality improvements labels Feb 28, 2024
@jfmcquade jfmcquade merged commit 233ece2 into master Feb 28, 2024
8 checks passed
@jfmcquade jfmcquade deleted the dependabot/npm_and_yarn/octokit-3.1.2 branch February 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance Core updates, refactoring and code quality improvements test - visual Run visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants