chore: activity should be locked when now countdown start date is pro…

…vided
IDEMSInternational · Dec 23, 2024 · ec7bd1a · ec7bd1a
1 parent 82f8d01
commit ec7bd1a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/.../components/plh/plh-kids-kw/components/activity-check-in/activity-check-in.component.html b/.../components/plh/plh-kids-kw/components/activity-check-in/activity-check-in.component.html
@@ -3,17 +3,19 @@
     class="activity-container"
     [attr.data-language-direction]="templateTranslateService.languageDirection()"
   >
-    <div class="progress-tracker">
-      <div class="progress-bar-container">
-        <div
-          class="progress-bar"
-          [ngStyle]="{
-            width: progressPercentage() + '%'
-          }"
-        ></div>
+    @if (params.countdownStartDate) {
+      <div class="progress-tracker">
+        <div class="progress-bar-container">
+          <div
+            class="progress-bar"
+            [ngStyle]="{
+              width: progressPercentage() + '%'
+            }"
+          ></div>
+        </div>
+        <div class="countdown-text">{{ countdownText() }}</div>
       </div>
-      <div class="countdown-text">{{ countdownText() }}</div>
-    </div>
+    }
 
     <div class="image">
       <img [src]="params.lockedImageAsset | plhAsset" />

diff --git a/...es/components/plh/plh-kids-kw/components/activity-check-in/activity-check-in.component.ts b/...es/components/plh/plh-kids-kw/components/activity-check-in/activity-check-in.component.ts
@@ -37,6 +37,8 @@ export class PlhActivityCheckInComponent extends TemplateBaseComponent implement
 
   daysUntilUnlock = signal(Infinity);
   locked = computed(() => {
+    // If no start date is provided, activity should be locked
+    if (!this.params.countdownStartDate) return true;
     return this.daysUntilUnlock() && this.daysUntilUnlock() > 0;
   });
   countdownText = computed(() => {
@@ -93,6 +95,7 @@ export class PlhActivityCheckInComponent extends TemplateBaseComponent implement
       // Attempt to parse from ISO format
       parsedDate = parseISO(countdownStartDate);
       if (!isValid(parsedDate)) {
+        parsedDate = null;
         console.error(
           `[ACTIVITY CHECK-IN] Invalid date for countdown_start_date: ${countdownStartDate}`
         );