chore: code tidy

IDEMSInternational · Jan 15, 2024 · a488e54 · a488e54
1 parent 0ca3a76
commit a488e54
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/app/shared/components/template/components/task-card/task-card.component.ts b/src/app/shared/components/template/components/task-card/task-card.component.ts
@@ -15,7 +15,8 @@ interface ITaskCardParams {
    */
   task_id: string;
   /**
-   * The ID of a task group, used to track whether it is the highlighted task group.
+   * The ID of a task group, within the config-level list app_config.TASKS.taskGroupsListName.
+   * Used to track whether it is the highlighted task group.
    * If provided, the task card will display a progress bar for the task group
    * **/
   task_group_id: string;

diff --git a/...pp/shared/components/template/components/task-progress-bar/task-progress-bar.component.ts b/...pp/shared/components/template/components/task-progress-bar/task-progress-bar.component.ts
@@ -153,7 +153,7 @@ export class TmplTaskProgressBarComponent
   }
 
   private checkAndSetUseDynamicData() {
-    this.useDynamicData = this.dataRows[0].hasOwnProperty(this.params.completedColumnName);
+    this.useDynamicData = this.dataRows?.[0]?.hasOwnProperty(this.params.completedColumnName);
   }
 
   private async evaluateTaskGroupData() {

diff --git a/src/app/shared/services/task/task.service.ts b/src/app/shared/services/task/task.service.ts
@@ -170,7 +170,7 @@ export class TaskService extends AsyncServiceBase {
     if (subtasksCompleted === subtasksTotal) {
       progressStatus = "completed";
       // Check whether task group has already been completed
-      if (this.templateFieldService.getField(completedField) !== true) {
+      if (!this.templateFieldService.getField(completedField)) {
         // If not, set completed field to "true"
         await this.setTaskGroupCompletedStatus(completedField, true);
         newlyCompleted = true;