-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed macosx tutorial to properly handle different mac arch possibi… #1544
Conversation
…lities with single command
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
- Coverage 77.06% 77.05% -0.01%
==========================================
Files 389 389
Lines 62680 62680
Branches 10276 10276
==========================================
- Hits 48303 48300 -3
- Misses 11939 11943 +4
+ Partials 2438 2437 -1 ☔ View full report in Codecov by Sentry. |
@azaidi06 will look at this today. |
Improve rendering with code-block
Added newline before the code-block directive to rectify rendering issue
removed extraneous backtick in the changed command to help with rendering
adding newline after code-block directive to render correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes (should be enough to hit "Commit suggestion")
remove numbering and re-add double quotes around second command Co-authored-by: Ludovico Bianchi <[email protected]>
…lities with single command
Fixes
This fixes issue #1497 : #1497
Summary/Motivation:
New Mac devices now come with apple silicon which requires a different set of binaries relative to previous intel version -- in order to accommodate both types, a single command is used to determine and download what's appropriate.
Changes proposed in this PR:
Simply changing the tutorial for Macs to accommodate the potential differences in CPU arch -- the command will be able to determine which arch is being used on the device and download the appropriate binaries. This will help mitigate potential mistakes of downloading the incorrect type/version for apple silicon vs intel.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: