Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'manual number' as supported source for 'test cases'. #9795

Merged

Conversation

fniessink
Copy link
Member

The 'test cases' metric had 'manual number' as supported source for the metric, but that could never work since the metric needs sources that contain test cases with identifiers so they can be matched.

Fixes #9793.

@fniessink fniessink linked an issue Sep 18, 2024 that may be closed by this pull request
docs/src/changelog.md Outdated Show resolved Hide resolved
@fniessink fniessink force-pushed the 9793-test-cases-metric-has-manual-number-as-supported-source branch from b211597 to b50a7c4 Compare September 18, 2024 21:58
The 'test cases' metric had 'manual number' as supported source for the metric, but that could never work since the metric needs sources that contain test cases with identifiers so they can be matched.

Fixes #9793.
@fniessink fniessink force-pushed the 9793-test-cases-metric-has-manual-number-as-supported-source branch from b50a7c4 to 8570430 Compare September 19, 2024 12:17
Copy link

sonarcloud bot commented Sep 19, 2024

@fniessink fniessink merged commit 98c2f54 into master Sep 19, 2024
38 of 40 checks passed
@fniessink fniessink deleted the 9793-test-cases-metric-has-manual-number-as-supported-source branch September 19, 2024 13:08
Copy link
Contributor

@wkoot wkoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test cases metric has manual number as supported source
2 participants