Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Remove unused NLP API and keep the only used NLP stage (
NER
).The other stages are irrelevant for Datashare (and probably in general).
This change is made in the context of #1452 and is a prerequisite for #1541 (which implements batch processing).
Changes
datashare-api
Removed
NlpStage
since Datashare only uses theNER
stageChanged
Pipeline
APIs toNlpStage
removaldatashare-core-nlp
Changed
CoreNlpPipelineModels
to the newPipeline
APIRemove
CoreNlpNerModels
,CoreNlpPosModels
datashare-app
EmailPipeline
to the newPipeline
API