fix: build and release extension jar #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClemDoum
force-pushed
the
release/jar
branch
6 times, most recently
from
69516eb
to
e91087a
Compare
ClemDoum
force-pushed
the
release/jar
branch
2 times, most recently
from
9b9211d
to
e64ae9c
Compare
pirhoo
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
neo4jand.circleci/config.ymlAdded
./neo4j publish -p neo4j_extensionCLI to build the extension jar (the JAR was forgotten in the assets to release, only the Python app binaries were released)Changed
--create-releaseflag to the./neo4j publishto create the GH release, when the flag is not there, the CLI will try to upload assets to an existing release