Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing neo4j password in local setting #153

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix: missing neo4j password in local setting #153

merged 2 commits into from
Jan 19, 2024

Conversation

ClemDoum
Copy link
Collaborator

@ClemDoum ClemDoum commented Jan 19, 2024 •
edited
Loading

PR description

Since Datashare doesn't display empty properties, we have to set the neo4j password to a non empty default value

Changes

src

Fixed

  • fix: set empty neo4j settings to non empty default values so that they appear in the setting view in local mode

neo4j-app

Changed

  • chore: change default neo4j URL scheme to bolt

@ClemDoum ClemDoum self-assigned this Jan 19, 2024
@ClemDoum ClemDoum added bug Something isn't working neo4j labels Jan 19, 2024
@ClemDoum ClemDoum marked this pull request as ready for review January 19, 2024 14:43
@ClemDoum ClemDoum requested a review from a team as a code owner January 19, 2024 14:43
@ClemDoum
Copy link
Collaborator Author

thanks @mvanzalu

@ClemDoum ClemDoum merged commit 8962af2 into main Jan 19, 2024
8 checks passed
@ClemDoum ClemDoum deleted the fix/password-setting branch January 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvanzalu mvanzalu mvanzalu approved these changes

Assignees

@ClemDoum ClemDoum

Labels
bug Something isn't working neo4j
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClemDoum @mvanzalu