Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally hide Result tab in SigAna #397

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conditionally hide Result tab in SigAna #397

wants to merge 2 commits into from

Conversation

PaulJonasJost
Copy link
Collaborator

Hide result tab for multiple visualizations in case only one compares on was used. Closes #388

@PaulJonasJost PaulJonasJost self-assigned this Nov 14, 2024
LeaSeep
LeaSeep requested changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@LeaSeep LeaSeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works - however if you have only one comparison the user needs to click on tab. Maybe as a quick fix would be helpful at least to mention that in the help box above - or immediately show the resulting tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeaSeep LeaSeep Awaiting requested review from LeaSeep

Requested changes must be addressed to merge this pull request.

Assignees

@PaulJonasJost PaulJonasJost

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulJonasJost @LeaSeep