Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Params update for ibm zos core 1.10 #253

Merged
merged 21 commits into from
Jun 26, 2024
Merged

Params update for ibm zos core 1.10 #253

merged 21 commits into from
Jun 26, 2024

Conversation

ketankelkar
Copy link
Member

@ketankelkar ketankelkar commented Apr 10, 2024 •
edited
Loading

With ibm_zos_core collection 1.10, certain options for certain modules become case-sensitive.
This PR updates the affected modules calls in playbooks

Some of the changes are backwards compatible. Others aren't. For the ones which aren't, the README at the playbook level has been updated to explain where playbooks compatible with older versions of the ibm_zos_core collection can be found

ketankelkar added 17 commits April 9, 2024 17:28
@ketankelkar
updates to initial set of playbooks
82648b8 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
removes task creating pds member since new behavior of zos_copy creat…
f56e42e 
…es it. also updates newly case-sensitive params

Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
update case sensitive params, update unsafe conditional, slightly red…
a631224 
…uce initial data set size

Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
updates top module options for volume init playbooks
f566046 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
update case-sensitive modules options in role, update unsafe jinja in…
86aaa96 
… conditional

Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
update module options copy fetch data set playbook
ec1230d 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
update module options constructs/zos job submit
46448df 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
update module options for templates playbooks
21cea9a 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
update module options and rename some variables for archive/unarchive…
1c036e8 
… playbooks, also adds some cleanup tasks

Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
update changelogs
776ef56 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
Merge branch 'main' into params-update-for-ibm_zos_core-1.10
bdc4783
@ketankelkar
Merge branch 'main' into params-update-for-ibm_zos_core-1.10
a770153
@ketankelkar
ibm_zos_core v1.10 release update to playbook README
bb3b79f 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
ibm_zos_core v1.10 release update to playbook README minor tweaks
1a8ab6f 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
tweak ibm_zos_core v1.10 release update to playbook README
74ccb60 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
ibm_zos_core v1.10 release update to playbook README
cec53f2 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
Merge branch 'main' into params-update-for-ibm_zos_core-1.10
f72e1ca
richp405
richp405 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the 'zport' problem is in roles.

fernandofloresg
fernandofloresg reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@fernandofloresg fernandofloresg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work Ketan. Will approve once is ready to review

zos_concepts/data_transfer/archive_copy_unarchive_restore/inventories/host_vars/source.yml Outdated
@@ -0,0 +1,24 @@
################################################################################
# Copyright (c) IBM Corporation 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright should be 2024

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! thanks!!

@ketankelkar
update copyright year
060391a 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar ketankelkar marked this pull request as ready for review June 25, 2024 18:38
@ketankelkar
Copy link
Member Author

@richp405 good observation regarding the zport, it looks like the files which were flagged are all under subsystems/ims project(s) and thus not related to the changes introduced in this PR. Looks like there's an open issue to address the zport thing anyhow - #215

@ketankelkar ketankelkar marked this pull request as draft June 25, 2024 19:36
@ketankelkar
Copy link
Member Author

converting back to draft so it is not accidentally merged before the supporting branch (ibm_zos_core-v1.9.x-samples) is created with updated playbooks

@ketankelkar
add links to README
e1d65c0 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
fix links in README
adf179f 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar
add links to README
6924383 
Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar ketankelkar marked this pull request as ready for review June 25, 2024 23:11
ddimatos
ddimatos approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@ddimatos ddimatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work Ketan.

@ddimatos
Copy link
Member

I like the solution, this keeps both earlier and later versions of the playbooks available to users.

@ketankelkar ketankelkar merged commit 4155f20 into main Jun 26, 2024
3 checks passed
@ketankelkar ketankelkar deleted the params-update-for-ibm_zos_core-1.10 branch June 26, 2024 16:22
@ketankelkar ketankelkar self-assigned this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richp405 richp405 richp405 approved these changes

@ddimatos ddimatos ddimatos approved these changes

@fernandofloresg fernandofloresg fernandofloresg approved these changes

Assignees

@ketankelkar ketankelkar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ketankelkar @ddimatos @fernandofloresg @richp405