-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor + dependabot #32
Changes from all commits
916b3d8
9259d41
0563d61
8609a11
b427754
0068b3a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
coverage[toml]>=6.5 | ||
pytest-cov==4.1.0 | ||
pytest==7.4.3 | ||
mkdocs-material==9.4.14 | ||
mkdocstrings[python] | ||
h5py==3.10.0 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
coverage[toml]>=6.5 | ||
pytest-cov==4.1.0 | ||
pytest==7.4.3 |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
# register models with timm | ||
import terratorch.models | ||
from terratorch.models.backbones import * # noqa: F403 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
import logging # noqa: I001 | ||
import os | ||
import warnings | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These datamodules are being imported but not used, right ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They are not being used, but they enable |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
from pathlib import Path | ||
from typing import Any | ||
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question asked for the other init file. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, same thing. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
import dataclasses | ||
import glob | ||
import os | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
"""Module containing generic dataset classes | ||
""" | ||
import glob | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
"""Module containing generic dataset classes | ||
""" | ||
import glob | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
import dataclasses | ||
import glob | ||
import os | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
# import so they get registered | ||
import terratorch.models.backbones.prithvi_swin | ||
import terratorch.models.backbones.prithvi_vit |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
import logging | ||
|
||
import torch | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
from terratorch.models.decoders.fcn_decoder import FCNDecoder | ||
from terratorch.models.decoders.identity_decoder import IdentityDecoder | ||
from terratorch.models.decoders.upernet_decoder import UperNetDecoder | ||
from terratorch.models.decoders.satmae_head import SatMAEHead, SatMAEHeadViT | ||
from terratorch.models.decoders.upernet_decoder import UperNetDecoder | ||
|
||
__all__ = ["FCNDecoder", "UperNetDecoder", "IdentityDecoder", "SatMAEHead", "SatMAEHeadViT"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
from torch import Tensor, nn | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Copyright contributors to the Terratorch project | ||
|
||
"""Pass the features straight through | ||
""" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which circumstances we want to perform the tests for individual pushes ? As we have the rule of creating PR before sending pushes to
main
I thought it was already covered by the pull request instruction.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a good point. Tbh I mostly took this from what I saw on TorchGeo. Could it be for the case where a force push to main happens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I believe it won't affect our current workflow, but it could cover the exceptional cases in which we need to directly push to the master. I agree.