Skip to content

Update demo-intrinsic to build granite3-rag #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Conversation

jgchn
Copy link
Collaborator

@jgchn jgchn commented Mar 7, 2025

Remove dependencies requirements in demo-hallucination.pdl by making the program run on its own. Updated pdl-live-react script.

@jgchn jgchn marked this pull request as ready for review March 21, 2025 21:28
@jgchn
Copy link
Collaborator Author

jgchn commented Mar 21, 2025

Hi @mandel, @vazirim, and @starpit I think this PR is ready for review with the main change documented here: https://github.com/jgchn/prompt-declaration-language/tree/demo/examples/intrinsics. I also updated pdl-live-react/demos/run.sh to include this demo (demo8).

However, I'm not sure how to fix the build test.

FAILED tests/test_ast_utils.py::test_ast_iterators - AssertionError: Internal error (missing case iter_block_children(<class 'pdl.pdl_ast.ArgsBlock'>))
FAILED tests/test_dump.py::test_dump - AssertionError: examples/intrinsics/demo-hallucination.pdl: AssertionError("Internal error (missing case iter_block_children(<class 'pdl.pdl_ast.ArgsBlock'>))")

Does this mean the ArgsBlock need to get tested? How do I approach this?

@jgchn jgchn closed this Mar 31, 2025
@jgchn jgchn deleted the demo branch March 31, 2025 20:33
@jgchn jgchn restored the demo branch March 31, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants