feat: port pdl-live to react+patternfly+vite #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starpit
force-pushed
the
react
branch
30 times, most recently
from
5c0d42f to
5e4286f
Compare
|
|
|
|
starpit
force-pushed
the
react
branch
23 times, most recently
from
e406f40 to
98c78ee
Compare
Also - updates the typescript source style to "no-semi" - switches from npm to yarn - adds github action test that invokes the pdl-live `yarn test` - `yarn test` currently tests: a) type checking; b) linting; c) formatting; d) basic playwright tests - `yarn test:quality` checks a-c - `yarn test:ui` checks d, using [playwright](https://playwright.dev/); see tests/*.ts Fixes IBM#251 Signed-off-by: Nick Mitchell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
yarn testyarn testcurrently tests: a) type checking; b) linting; c) formatting; d) basic playwright testsyarn test:qualitychecks a-cyarn test:uichecks d, using playwright; see tests/*.tsFixes #251