Vanilla radar - initial commit #42
Conversation
|
I just realized the example folder has a full Vanilla JS Radar chart example fully coded. For some reason I was under the impression they just animated polygons and didn't use data.... Horray for duplicating work! |
|
@ninth-mind do you want to keep working on this branch or try to extract their code to a package? |
|
@seejamescode -- yeah... im going to add the interactions, and adapt it a little bit to make it a little more consumable. |
…into vanilla-radar
Vanilla Radar Import Fix
|
@seejamescode -- @photodow helped me set up webpack and get rid of the lint errors. Working on interactions now. |
|
Maybe we should work on getting this pull request merged first before moving on to interactions and making this pull request larger. |
|
Let me know when you are ready for me to approve a base pr |
|
|
||
|
|
||
| } else if (this.cfg.shape == 'polygon') { | ||
| //TODO |
There was a problem hiding this comment.
Need to write a user story around this polygon shape.
There was a problem hiding this comment.
Still want me to merge it now?
There was a problem hiding this comment.
@seejamescode if you've looked at the code, and are happy with it then it should be merged. I created stories for these to do's, and we can tackle them after this pull request goes in.
| } else if (this.cfg.shape == 'polygon') { | ||
| //TODO | ||
| } else if (this.cfg.shape == 'square') { | ||
| //TODO |
There was a problem hiding this comment.
Need to write a user story around this square shape.
|
|
||
| describe('Radar Component', () => { | ||
| it('should render', () => { | ||
| expect(true).toBe(true, 'This is a placeholder true'); |
There was a problem hiding this comment.
I imagine we should probably add tests for these? @seejamescode
Closes #36
Initial attempt at Vanilla Radar graph.
Included some dev dependencies to help with prototyping. (gulp, gulp-babel, gulp-sass)
Fudged Tests to always return true.
Not to visual specs.