Add new @vocabulary and @vocabulary-uri attributes for elements relating to aid-type #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalepotter
changed the title
dalepotter
suggested changes
Dec 5, 2017
iati-activities-schema.xsd
Outdated
| @@ -2804,5 +2806,13 @@ | |||
| </xsd:annotation> | |||
| </xsd:attribute> | |||
|
|
|||
| <xsd:attribute name="vocabulary" type="xsd:string"> | |||
There was a problem hiding this comment.
vocabulary is a commonly-used term, so would suggest naming this aidTypeVocabulary.
| <iati-activities version="xx"> | ||
| <iati-activity> | ||
| <iati-identifier></iati-identifier> | ||
| <reporting-org type="xx" ref="xx"><narrative>Organisation name</narrative></reporting-org> |
There was a problem hiding this comment.
For info, I've added an issue to fix the formatting of this line en masse before release: #403
|
@dalepotter ready for rereview |
dalepotter
suggested changes
Dec 6, 2017
iati-activities-schema.xsd
Outdated
| </xsd:annotation> | ||
| </xsd:attribute> | ||
|
|
||
| <xsd:complexType name="aid-type-base"> |
There was a problem hiding this comment.
I think we tend to name complexTypes using lower camel case - e.g. in https://github.com/IATI/IATI-Schemas/pull/372/files#diff-644a12e8a6ade95722e1f3adf60b7462R148
|
@dalepotter ready for rerereview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346 for schema