-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorganizing and adding docs #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes. See also: iiasa/aneris#64 (comment) |
Got it, thanks! |
This is good to go now, noting existing conflicts.. |
I rebased this on the latest changes on main and then added to fixup commits to stuff i'd have done differently (for the path resolution for regionmappings and how to check for a single model) |
This was referenced Apr 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @coroa this PR does a few things
config.yaml
andworkflow.py
to streamline data locations, specifically requiring paths for history, scenarios (I see now it has proxies and gridding, maybe we want to further reduce this..)config.yaml
from git trackingconfig.yaml
and start to think about how to support running the workflows for multiple models/scenariosI did a poor man's version of your path expansion to support configured paths in the region mapping, feel free to rip that apart.
Here's the version of my config I have on disk.
Everything now lives in a single directory (
data_path
), which I can host on sharepoint (it's just copied over from our previous folder):...\RESCUE - Documents\WP 1\data_2024_03_14
A next step would be to set up the gridding proxy and masks to write into these locations.
Let me know what you think!