-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UID2-4808 change policy to enum #378
Open
cYKatherine
wants to merge
8
commits into
main
Choose a base branch
from
kcc-UID2-4808-change-policy-to-enum
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollins-ttd
reviewed
Feb 7, 2025
Comment on lines
+4
to
+26
GCP_OIDC, | ||
GCP_VMID, | ||
AWS_NITRO, | ||
AZURE_CC_ACI, | ||
AZURE_CC_AKS; | ||
|
||
public String toString() { | ||
switch(this) { | ||
case GCP_OIDC: | ||
return "gcp-oidc"; | ||
case GCP_VMID: | ||
return "gcp-vmid"; | ||
case AWS_NITRO: | ||
return "aws-nitro"; | ||
case AZURE_CC_ACI: | ||
return "azure-cc"; | ||
case AZURE_CC_AKS: | ||
return "azure-cc-aks"; | ||
default: | ||
return "unknown-protocol"; | ||
} | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
GCP_OIDC, | |
GCP_VMID, | |
AWS_NITRO, | |
AZURE_CC_ACI, | |
AZURE_CC_AKS; | |
public String toString() { | |
switch(this) { | |
case GCP_OIDC: | |
return "gcp-oidc"; | |
case GCP_VMID: | |
return "gcp-vmid"; | |
case AWS_NITRO: | |
return "aws-nitro"; | |
case AZURE_CC_ACI: | |
return "azure-cc"; | |
case AZURE_CC_AKS: | |
return "azure-cc-aks"; | |
default: | |
return "unknown-protocol"; | |
} | |
} | |
GCP_OIDC("gcp-oidc"), | |
GCP_VMID("gcp-vmid"), | |
AWS_NITRO("aws-nitro"), | |
AZURE_CC_ACI("azure-cc"), | |
AZURE_CC_AKS("azure-cc-aks"); | |
private final String value; | |
Protocol(String value) { | |
this.value = value; | |
} | |
@Override | |
public String toString() { | |
return this.value; | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.