-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password policy improvements #589
Changes from 5 commits
1fcd8cd
5224864
92b9792
aa9f4d1
a6e026d
549ec01
6b4ff75
b61341f
e8e45ff
e69ec46
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,8 @@ | |
<div class="centralize-content"> | ||
<#-- App-initiated actions should not see warning messages about the need to complete the action --> | ||
<#-- during login. --> | ||
<#if displayMessage && message?has_content && (message.type != 'warning' || !isAppInitiatedAction??)> | ||
<br /> | ||
<#if displayMessage && message?has_content && message.type != 'warning' && !isAppInitiatedAction??> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just taking out the parentheses fixed the logic here and no longer shows the "activate your account" message but still shows the error messages if someone inputs the wrong password |
||
<div class="alert-${message.type} ${properties.kcAlertClass!} pf-m-<#if message.type = 'error'>danger<#else>${message.type}</#if>"> | ||
<div class="pf-c-alert__icon"> | ||
<#if message.type = 'success'><span class="${properties.kcFeedbackSuccessIcon!}"></span></#if> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
import { useKeycloak } from '@react-keycloak/web'; | ||
import { StrictMode, useCallback, useContext } from 'react'; | ||
import { Outlet, useLocation } from 'react-router-dom'; | ||
Check warning on line 3 in src/web/App.tsx GitHub Actions / build (20.x)
|
||
|
||
import { EnvironmentBanner } from './components/Core/Banner/EnvironmentBanner'; | ||
import { ErrorView } from './components/Core/ErrorView/ErrorView'; | ||
|
@@ -24,12 +24,11 @@ | |
const { LoggedInUser } = useContext(CurrentUserContext); | ||
const { participant } = useContext(ParticipantContext); | ||
const isLocalDev = process.env.NODE_ENV === 'development'; | ||
const location = useLocation(); | ||
|
||
if (LoggedInUser?.user?.participants!.length === 0) { | ||
return <ErrorView message='You do not have access to any participants.' />; | ||
} | ||
if (location.pathname !== '/account/create' && LoggedInUser && !participant) { | ||
if (LoggedInUser && !participant) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this account/create page does not exist anymore and should be removed. randomly found this when testing stuff |
||
return <NoParticipantAccessView user={LoggedInUser?.user} />; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulling from this file, but we can also store the txt file in our code if that makes sense too. i went with this option because i didnt want to take up space in the code for a huge file, but it would be an issue if this URL changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love relying on a 3rd party to be up in order for our blacklist to work. You can just save the file locally and load it from there, too.