Added a few fields required for full support for version 4.0 and more #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytro-babichev
suggested changes
Jan 29, 2025
| @@ -219,6 +219,12 @@ message SKAdNetworkRequest { | |||
| // "2.0" or higher. Dependent on both the OS version and the SDK version. | |||
| repeated string versions = 5; | |||
|
|
|||
| // Custom Product Page support. | |||
| optional int32 productpage = 6; | |||
There was a problem hiding this comment.
this can be boolean in protobuf
| optional int32 productpage = 6; | ||
|
|
||
| // SKOverlay support. If set, SKOverlay is supported. | ||
| optional int32 skoverlay = 7; |
There was a problem hiding this comment.
this can be boolean in protobuf
| optional int32 endcarddelay = 2; | ||
|
|
||
| // Whether the overlay can be dismissed by the user, where 0 = no, 1 = yes | ||
| optional int32 dismissible = 3; |
dmytro-babichev
approved these changes
Jan 31, 2025
Symbols-max
approved these changes
Jan 31, 2025
reshmin
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fields
productpage,skoverlayforBidRequest.imp.ext.skadnobject andsourceidentifier,productpageid,skoverlayforBidResponse.seatbid.bid.ext.skadnobject.