Add more integration tests for person service #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bayehyg for attempting this issues , can you resolve the conflicts |
|
👋 Hi, @bayehyg, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
and generally, do we need to have more than one text method in the same class? |
sherrif10
reviewed
Apr 23, 2024
| firstName = "Malik"; | ||
| lastName = "Sardar"; | ||
| personId = "1234"; | ||
| cellPhone = "403-678-5678"; |
There was a problem hiding this comment.
Phone number should start with country code for the test to more clear.
Some merge Conflicts to solve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests Requirements
Summary
-Added integration tests to cover functions supported by the PersonServic.
-Refactored test setup for improved organization and efficiency.
Related Issue
#Add more integration tests to the Patient and Person service #902