Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for MenuService #1217

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

Agaba-derrick
Copy link
Contributor

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Screenshots

Screenshot from 2024-08-02 11-20-27

Related Issue

Add intergration Tests for menu #1216

Other

@mozzy11 kindly review this

Copy link
Contributor

@mherman22 mherman22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agaba-derrick please run mvn spotless:apply to fix the formatting of this PR and fix the failing build

@Agaba-derrick
Copy link
Contributor Author

Screenshot from 2024-08-03 22-14-43

Copy link
Contributor

@mherman22 mherman22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agaba-derrick try to align your test methods to some of the suggestions i have added otherwise this looks fine already

Copy link
Contributor

@mherman22 mherman22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿

cc: @mozzy11

Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Agaba-derrick for adding more Intergration tests for the Menu Service,
However am seeing alot of added test which are simply units test and not Integration TEsts for the Menu service.
Can you remove those

@Agaba-derrick
Copy link
Contributor Author

@mozzy11 i notice that even after running maven spotless:apply the CI builds still fail !!

Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Agaba-derrick for the PR.
Can you remove all the methods that dont test the MenuService ??

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
@Agaba-derrick
Copy link
Contributor Author

Thanks @Agaba-derrick for the PR. Can you remove all the methods that dont test the MenuService ??
yes sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants