fix(CA): Genesis Location #597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locationfix
for more information, see https://pre-commit.ci
cdnninja
reviewed
Jul 22, 2024
| @@ -422,11 +422,11 @@ def _update_vehicle_properties_service(self, vehicle: Vehicle, state: dict) -> N | |||
| def _update_vehicle_properties_location( | |||
| self, vehicle: Vehicle, state: dict | |||
| ) -> None: | |||
| if get_child_value(state, "coord.lat"): | |||
| if get_child_value(state, "gpsDetail.coord.lat"): | |||
There was a problem hiding this comment.
Wouldn't this break other brands within Canada?
|
Not sure. Be interesting to know if it's the same across Hyundai and Kia.
Could make it conditional on brand. That would point to them diverging
across brands.
…On Mon, Jul 22, 2024, 3:10 p.m. cdnninja ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In hyundai_kia_connect_api/KiaUvoApiCA.py
<#597 (comment)>
:
> @@ -422,11 +422,11 @@ def _update_vehicle_properties_service(self, vehicle: Vehicle, state: dict) -> N
def _update_vehicle_properties_location(
self, vehicle: Vehicle, state: dict
) -> None:
- if get_child_value(state, "coord.lat"):
+ if get_child_value(state, "gpsDetail.coord.lat"):
Wouldn't this break other brands within Canada?
—
Reply to this email directly, view it on GitHub
<#597 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFASXNXMIJFSSRTIWVM4GLLZNVKJZAVCNFSM6AAAAABLI4RPISVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOJSGM3DMMJSGE>
.
You are receiving this because you authored the thread.Message ID:
<Hyundai-Kia-Connect/hyundai_kia_connect_api/pull/597/review/2192366121@
github.com>
|
|
How about we scream test? We can make the change and see if we get reports of issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to resolve issue #906 in kia_uvo
Updated URL for location request.