Skip to content

Implement mod implementation interface for use in downstream mods #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

ConnorLinfoot
Copy link
Member

This change will provide better expansion moving forward for the downstream mod implementations, for now, the major addition is allowing downstream mods to track if we are connected to Hypixel to prevent sending plugin messages when we're not.

@ConnorLinfoot ConnorLinfoot changed the title Implement HypixelModImplementation for use in downstream mods Implement mod implementation interface for use in downstream mods Apr 1, 2025
@ConnorLinfoot ConnorLinfoot merged commit aa6925a into master Apr 1, 2025
@ConnorLinfoot ConnorLinfoot deleted the mod-impl branch April 1, 2025 13:46
ConnorLinfoot added a commit to HypixelDev/ForgeModAPI that referenced this pull request Apr 1, 2025
ConnorLinfoot added a commit to HypixelDev/FabricModAPI that referenced this pull request Apr 1, 2025
@Yedelo
Copy link

Yedelo commented Apr 6, 2025

Glad to see you're still working on this.

Does this mean you don't have to install the mod to use the mod api, only needing to shadow it and provide your own implementation?
Also, you should add an isModImplementationPresent method, since there is currently no pleasant way to see if there is an implementation provided (you have to use reflection or catch the exception in setModImplementation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants