Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed translate _ being overwritten in elevate email confirmation #4451

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

wes-otf
Copy link
Contributor

@wes-otf wes-otf commented Mar 12, 2025

Fixes #4450 as the translate _(...) was being overwritten earlier in the code

@wes-otf wes-otf requested a review from frjo March 12, 2025 14:42
@wes-otf wes-otf added Type: Patch Mini change, used in release drafter Type: Bug Bugs! Things that are broken :-/ labels Mar 12, 2025
@@ -724,7 +724,7 @@ def get_pending_signup(self, uidb64):
@login_required
def send_confirm_access_email_view(request):
"""Sends email with link to login in an elevated mode."""
token_obj, _ = ConfirmAccessToken.objects.update_or_create(
token_obj, created = ConfirmAccessToken.objects.update_or_create(
Copy link
Member

@theskumar theskumar Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !

@frjo frjo merged commit 7bd1bc1 into main Mar 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to get email sent in elevate prompt results in an error
3 participants